Greptile Summary

This PR allows LSP plugin authors to override both document URI and root URI resolution by adding a new documentUri hook to LspServerDefinition/LspServerManifest. It also fixes a long-standing priority bug where a caller-supplied context.rootUri would always short-circuit any server-specific rootUri function.

Key changes:

• New documentUri hook: Plugins can now return a custom document URI via server.documentUri(originalUri, context). The hook receives the original URI and the auto-normalized URI.
• Per-server URI resolution: #resolveDocumentUri is now called inside the server loop, so different servers attached to the same file can resolve to different URIs.
• URI alias map: When originalUri !== normalizedUri, the original URI is registered as an alias in a new uriAliases map inside ClientState, ensuring external detach(originalUri) calls correctly reach the right fileRefs entry.
• #resolveRootUri priority fix: server.rootUri function is now evaluated before context.rootUri, fixing Codemirror LSP not using uri I passed #1996.
• Async-capable hooks: Both rootUri and documentUri now accept MaybePromise return values.

The formatDocument path calls state.attach(normalizedUri, view) without aliases (unlike getExtensionsForFile), leaving a pre-existing gap now inconsistent with the new alias mechanism.

Confidence Score: 5/5

Safe to merge — core logic is well-structured, all findings are P2 style/consistency suggestions, and no regressions are introduced.

All three comments are P2: one notes a pre-existing inconsistency in formatDocument (not a regression), one suggests exporting MaybePromise, and one flags the intentional #resolveRootUri priority change as worth documenting. None represent a current defect on the primary attach/detach path exercised by getExtensionsForFile.

src/cm/lsp/clientManager.ts — the formatDocument attach-without-aliases gap and the #resolveRootUri reorder are both in this file.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant EM as editorManager
    participant CM as LspClientManager
    participant RDU as resolveDocumentUri
    participant RRU as resolveRootUri
    participant CS as ClientState

    EM->>CM: getExtensionsForFile(metadata)
    loop for each matching server
        CM->>RDU: resolveDocumentUri(server, context)
        RDU->>RDU: normalizeDocumentUri(originalUri)
        alt normalizedUri is null
            RDU->>RDU: buildFileUri(file.cacheFile)
        end
        alt server.documentUri is function
            RDU->>RDU: await server.documentUri(originalUri, ctx+normalizedUri)
        end
        RDU-->>CM: normalizedUri (or null, skip server)
        CM->>RRU: resolveRootUri(server, context)
        Note over RRU: Priority: server.rootUri fn, context.rootUri, options.resolveRoot
        RRU-->>CM: rootUri
        CM->>CS: attach(normalizedUri, view, aliases=[originalUri])
        Note over CS: uriAliases: originalUri to normalizedUri
    end

    EM->>CM: detach(originalUri, view)
    CM->>CS: detach(originalUri, view)
    Note over CS: actualUri = uriAliases.get(originalUri) = normalizedUri
    CS->>CS: fileRefs.delete(normalizedUri)
    CS->>CS: cleanup uriAliases entries pointing to normalizedUri
    CS->>CS: workspace.closeFile(normalizedUri)

_{Reviews (1): Last reviewed commit: "fix(lsp): allow plugins to override docu..." | Re-trigger Greptile}